[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49494] [PATCH 0/7] Add nncp
From: |
Sarah Morgensen |
Subject: |
[bug#49494] [PATCH 0/7] Add nncp |
Date: |
Thu, 22 Jul 2021 18:22:24 -0700 |
Hi,
I have a few suggestions for this one as well.
Arun Isaac <arunisaac@systemreboot.net> writes:
> * gnu/packages/uucp.scm (nncp): New variable.
> ---
> gnu/packages/uucp.scm | 99 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 99 insertions(+)
>
> diff --git a/gnu/packages/uucp.scm b/gnu/packages/uucp.scm
> index 1bb4fdb975..2d4d1ae8d0 100644
> --- a/gnu/packages/uucp.scm
> +++ b/gnu/packages/uucp.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2021 Arun Isaac <arunisaac@systemreboot.net>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -17,6 +18,8 @@
> ;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>
> (define-module (gnu packages uucp)
> + #:use-module (gnu packages golang)
> + #:use-module (gnu packages texinfo)
> #:use-module (guix licenses)
> #:use-module (guix packages)
> #:use-module (guix download)
> @@ -54,3 +57,99 @@
> set of utilities for remotely transferring files, email and net news
> between computers.")
> (license gpl2+)))
> +
> +(define-public nncp
> + (package
> + (name "nncp")
> + (version "7.2.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "http://www.nncpgo.org/download/nncp-"
> + version ".tar.xz"))
> + (sha256
> + (base32
> + "0xsh5zc6i8nbcsi06r65lpp26hz2zb4vh0pzbkivdd69hrxvknvh"))
> + (modules '((ice-9 ftw)
> + (guix build utils)))
> + (snippet
> + '(begin
> + ;; Unbundle dependencies.
> + ;; TODO: go.cypherpunks.ru was down at the time of
> + ;; packaging. Unbundle go.cypherpunks dependencies as well once it
> + ;; comes back online.
> + (for-each (lambda (file)
> + (unless (member file (list "." ".."
> "go.cypherpunks.ru"))
> + (delete-file-recursively (string-append
> "src/vendor/" file))))
> + (scandir "src/vendor"))
> + ;; Delete built documentation.
> + (delete-file "doc/nncp.info")
> + #t))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; tests fail
It is not a good idea to just disable tests without knowing why they
fail (and leaving a comment explaining why).
> + #:modules ((guix build gnu-build-system)
> + ((guix build go-build-system) #:prefix go:)
> + (guix build union)
^ this module isn't necessary
> + (guix build utils))
> + #:imported-modules (,@%gnu-build-system-modules
> + (guix build union)
> + (guix build go-build-system))
This can probably just be
#:imported-modules ,%go-build-system-modules
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'unpack 'setup-go-environment
> + (assoc-ref go:%standard-phases 'setup-go-environment))
> + (add-after 'unpack 'go-unpack
> + (lambda* (#:key source #:allow-other-keys)
> + ;; Copy source to GOPATH.
> + (copy-recursively "src" "../src/go.cypherpunks.ru/nncp/v7")
> + ;; Move bundled dependencies to GOPATH.
> + (for-each (lambda (dependency)
> + (rename-file (string-append
> "src/vendor/go.cypherpunks.ru/"
> + dependency)
> + (string-append
> "../src/go.cypherpunks.ru/"
> + dependency)))
> + (list "balloon" "recfile"))
> + ;; Delete empty bundled dependencies directory.
> + (delete-file-recursively "src/vendor")))
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; Set output directories.
> + (let ((out (assoc-ref outputs "out")))
> + (setenv "BINDIR" (string-append out "/bin"))
> + (setenv "INFODIR" (string-append out "/share/info"))
> + (setenv "DOCDIR" (string-append out "/share/doc/nncp")))
Consider perhaps:
(setenv "DOCDIR" (string-append out "/share/doc/nncp"
,(package-version this-package)))
Does CFGPATH need to be set?
> + ;; Remove module flags.
> + (substitute* (list "bin/default.do" "test.do")
> + ((" -mod=vendor") "")
> + ((" -m") "")))))))
I took a quick look at the source and it looks like you'll also need:
(substitute* '("src/toss_test.go" "src/pipe.go")
(("/bin/sh") (which "sh")))
(substitute* "src/toss_test.go"
(("; cat") (string-append "; " (which "cat"))))
Which also makes the tests succeed.
> + (inputs
> + `(("go" ,go)))
> + (native-inputs
> + `(("texinfo" ,texinfo)))
> + (propagated-inputs
> + `(("go-github-com-davecgh-go-xdr" ,go-github-com-davecgh-go-xdr)
> + ("go-github-com-dustin-go-humanize" ,go-github-com-dustin-go-humanize)
> + ("go-github-com-flynn-noise" ,go-github-com-flynn-noise)
> + ("go-github-com-gorhill-cronexpr" ,go-github-com-gorhill-cronexpr)
> + ("go-github-com-hjson-hjson-go" ,go-github-com-hjson-hjson-go)
> + ("go-github-com-klauspost-compress" ,go-github-com-klauspost-compress)
> + ("go-golang-org-x-crypto" ,go-golang-org-x-crypto)
> + ("go-golang-org-x-net" ,go-golang-org-x-net)
> + ("go-golang-org-x-term" ,go-golang-org-x-term)
> + ("go-lukechampine-com-blake3" ,go-lukechampine-com-blake3)))
Since this is an end-user package, these can be regular inputs.
I also notice that nncp can use `sendmail`; should `sendmail` be an
input as well?
> + (home-page "http://www.nncpgo.org/")
> + (synopsis "Store and forward utilities")
> + (description "NNCP (Node to Node copy) is a collection of utilities
> +simplifying secure store-and-forward files, mail and command exchanging.
> +These utilities are intended to help build up small size (dozens of nodes)
> +ad-hoc friend-to-friend (F2F) statically routed darknet delay-tolerant
> +networks for fire-and-forget secure reliable files, file requests, Internet
> +mail and commands transmission. All packets are integrity checked,
> end-to-end
> +encrypted, explicitly authenticated by known participants public keys. Onion
> +encryption is applied to relayed packets. Each node acts both as a client
> and
> +server, can use push and poll behaviour model. Multicasting areas, offline
> +sneakernet/floppynet, dead drops, sequential and append-only CD-ROM/tape
> +storages, air-gapped computers and online TCP daemon with full-duplex
> +resumable data transmission exists are all supported.")
> + (license gpl3)))
This package is also retaining references to the Go compiler package;
re-adding this phase from go-build-system fixes that:
(add-after 'install 'remove-go-references
(assoc-ref go:%standard-phases 'remove-go-references))
--
Sarah
- [bug#49494] [PATCH 0/7] Add nncp, Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 1/7] gnu: Add go-github-com-davecgh-go-xdr., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 2/7] gnu: Add go-github-com-dustin-go-humanize., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 3/7] gnu: Add go-lukechampine-com-blake3., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 4/7] gnu: Add go-golang-org-x-term., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 5/7] gnu: Add go-github-com-flynn-noise., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 7/7] gnu: Add nncp., Arun Isaac, 2021/07/09
- [bug#49494] [PATCH 0/7] Add nncp,
Sarah Morgensen <=
- [bug#49494] [PATCH 6/7] gnu: Add go-github-com-klauspost-compress., Arun Isaac, 2021/07/09