[bug#49025] [PATCH v5 01/20] utils: Define target-linux? predicate.

[Maxime Devos]

Mathieu Othacehe schreef op ma 12-07-2021 om 14:35 [+0200]:
> Hey,
> 
> > +(define* (target-linux? #:optional (target (or (%current-target-system)
> > +                                               (%current-system))))
> 
> You can add a docstring here, something like:
> 
>   "Is the operating system of TARGET Linux?"

The Linux kernel by itself doesn't make an operating system,
as the kernel doesn't have a package manager, display manager,
basic text editors, application to configure network connections ...,
so I made this 

  "Does the operating system of TARGET use the Linux kernel?"

> > +  (string-contains target "linux"))
> 
> You should use the "->bool" procedure to return a boolean here.

Done in v5.

> >  (define* (target-mingw? #:optional (target (%current-target-system)))
> 
> You can add a docstring, something like:
> 
>   "Is the operating system of TARGET Windows 32 bits?"

Done in v5, but I dropped the '32-bits' and added a comment:

       ;; The "-32" doesn't mean TARGET is 32-bit, as "x86_64-w64-mingw32"
       ;; is a valid triplet (see the (gnu ci) module) and 'w64' and 'x86_64'
       ;; are 64-bit.

I wouldn't know what the "32" in "mingw32" refers to.

> > +  (map (compose ->bool target-linux?)
> 
> target-linux? should return a boolean
> 
> > +(test-equal "target-mingw?"
> > +  '(#f #f #t)
> > +  (map (compose ->bool target-mingw?)
> 
> You can write:
> 
> --8<---------------cut here---------------start------------->8---
>   (map target-mingw?
>        '("i686-linux-gnu" "i686-pc-gnu" "i686-w64-mingw32")))
> --8<---------------cut here---------------end--------------->8---
> 
> here.

Done in v5.  I'll send the v5 once everything is tested again
and commits have been properly rebased.

Greetings,
Maxime.

signature.asc
Description: This is a digitally signed message part