[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49419] [PATCH 1/4] home-services: Add most essential home services
From: |
Maxime Devos |
Subject: |
[bug#49419] [PATCH 1/4] home-services: Add most essential home services |
Date: |
Mon, 05 Jul 2021 21:19:08 +0200 |
User-agent: |
Evolution 3.34.2 |
Andrew Tropin schreef op ma 05-07-2021 om 19:19 [+0300]:
> Maxime Devos <maximedevos@telenet.be> writes:
>
> [...]
>
> BTW, how to add changes to the patches? Do I need to resend a
> particular patch with required updates or have to wait other reviews and
> send a v2 patch series?
I would do a combination of those: reply to the mail of the reviewer with a
revised patch attached. When you have received a ‘sufficient’ number of reviews
from others on the other patches in the series as well, send a v2.
Some benefits of this method:
(1) it should be clear which patches should be applied,
as the number of 'revised patches' without sending a new series
version is limited.
This is also the case if you send a new version after each little change,
but can easily become _not_ the cas if you always respond with a revised
patch without starting a new series version.
(2) you don't clutter the mailboxes with new version after new version
after each little change.
This is particularily important if you have large patch series (say 13 or
more patches), which doesn't seem to apply here.
WDYT?
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
[bug#49419] [PATCH 2/4] home-services: Add home-run-on-change-service-type, Andrew Tropin, 2021/07/05
[bug#49419] [PATCH 3/4] home-services: Add home-provenance-service-type, Andrew Tropin, 2021/07/05
[bug#49419] [PATCH 4/4] home-services: Add fold-home-service-types function, Andrew Tropin, 2021/07/05
[bug#49419] [PATCH v2 0/4] Essential home services, Andrew Tropin, 2021/07/13