guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#49310] website: Redesign video pages


From: Luis Felipe
Subject: [bug#49310] website: Redesign video pages
Date: Sat, 03 Jul 2021 17:01:28 +0000

Hi Florian,

On Saturday, July 3rd, 2021 at 10:08 AM, pelzflorian (Florian Pelz) 
<pelzflorian@pelzflorian.de> wrote:

> Thank you! Much nicer than before, both in looks and code-wise and
>
> also documentation-wise. This was much effort.

Phew, glad to hear that!


> Shall I push your commit and afterwards redirect the old video URLs in
>
> maintenance.git?

Maybe better to redirect to /en/videos/?


> I don’t know the plan for further videos and if forcing reverse
>
> chronological order will be useful someday.

Well, yeah, I'm not sure whether it will be useful either.

I think the idea is to add a selection of videos from the community, as 
proposed by Julien in https://issues.guix.gnu.org/43871. So the list could grow 
enough to justify a reverse chronological order, like in the blog.


> > New miniature and poster images for videos:
> >
> > -   website/static/media/videos/2018/seagl-everyday-use-of-guix.mini.webp
> > -   website/static/media/videos/2018/seagl-everyday-use-of-guix.webp
> >
> >     […]
>
> Yes, switching from .png to .webp seems appropriate, even if it is
>
> unsupported on old still-supported macOS versions or ReactOS or such
>
> things, because they cannot playback the .webm videos anyway, I think.

I'd say let's use webp and webm, and if we get complaints, we see how to solve 
any issues (at least for images; with videos is harder because of storage 
resources).


> > diff --git a/website/apps/media/builder.scm b/website/apps/media/builder.scm
>
> “#:use-module (srfi srfi-1)“ can be removed.

Removed in the new patch attached.


> > Modified files:
> >
> > -   website/apps/media/data.scm (videos): New list of videos plus
> >
> >     playlists.
> >
> >     (playlist): Remove in favor of the new videos list.
>
> s/(playlist)/(playlists)/

Corrected in the new patch.

Thanks for the review, Florian.

Attachment: 0001-website-Redesign-video-pages.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]