guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#48943] [PATCH] import: hackage: Support "common" field and imports


From: Ludovic Courtès
Subject: [bug#48943] [PATCH] import: hackage: Support "common" field and imports
Date: Sun, 13 Jun 2021 22:34:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Hi,

Philip Munksgaard <philip@munksgaard.me> skribis:

> Fixes <https://issues.guix.gnu.org/48701>.
>
> * guix/import/cabal.scm (make-cabal-parser): Modify.
> (is-common): New variable.
> (lex-common): New procedure.
> (is-id): Modify.
> (eval-cabal): Modify.

Could you add a test case in ‘tests/hackage.scm’ and send an updated
patch?

Apart from that it LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]