[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48556: [PATCH 0/4] Add keep-alive support to guix publish.
From: |
Mathieu Othacehe |
Subject: |
bug#48556: [PATCH 0/4] Add keep-alive support to guix publish. |
Date: |
Tue, 01 Jun 2021 09:14:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hey Ludo!
Thanks for having a look :).
> Also, this is specifically about keep-alive support for nar requests,
> right? My understanding is that other requests (narinfo in particular)
> already benefit from keep-alive support in (web server).
Yes that's right.
> Maybe it would be clearer if this were done at the call site, in
> ‘http-write’, where we can see the ‘close-port’ call a few lines below.
I took your remarks into account, merged two patches and reorganized
them a bit before pushing.
> Did you have a chance to try out the whole patch series “in production”?
> It would be nice to try it out so we can catch any issues we might have
> overlooked (random I/O errors, FD leaks, etc.)
I only tested it locally, but I'll monitor closely the impact of this
patchset on Berlin.
Thanks,
Mathieu
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#48556: [PATCH 0/4] Add keep-alive support to guix publish.,
Mathieu Othacehe <=