guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#48697] [PATCH] import: Add CHICKEN egg importer.


From: Xinglu Chen
Subject: [bug#48697] [PATCH] import: Add CHICKEN egg importer.
Date: Mon, 31 May 2021 20:00:51 +0200

On Mon, May 31 2021, Ludovic Courtès wrote:

> Heya,
>
> Xinglu Chen <public@yoctocell.xyz> skribis:
>
>> On Sat, May 29 2021, Ludovic Courtès wrote:
>
> [...]
>
>>>> +(define (find-latest-version name)
>>>> +  "Get the latest version of the egg NAME."
>>>> +  (let ((directory (scandir (egg-directory name))))
>>>> +    (if directory
>>>> +        (last directory)
>>>> +        (begin
>>>> +          (format #t (G_ "Package not found in eggs repository: ~a~%") 
>>>> name)
>>>> +          #f))))
>>>
>>> This should be rendered with ‘warning’ from (guix diagnostics).
>>>
>>> Or maybe it should be raised as a ‘formatted-message’ exception?
>>
>> Not sure if it should be an exception or not, if you run ‘guix import egg’
>> on a package that doesn’t exist, it will already throw an error
>>
>> $ ./pre-inst-env guix import egg lasdkfj
>> Package not found in eggs repository: lasdkfj
>> guix import: error: failed to download meta-data for package 'lasdkfj'
>
> True!  So perhaps we can omit the extra message altogether since it
> doesn’t convey any more info.

That would work as well. :)

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]