[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47174] [PATCH 0/2] substitute: Handle closing connections to substi
From: |
Ludovic Courtès |
Subject: |
[bug#47174] [PATCH 0/2] substitute: Handle closing connections to substitute servers. |
Date: |
Sat, 29 May 2021 23:41:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Chris,
Christopher Baines <mail@cbaines.net> skribis:
> Rather than just the port and response-content-length. I'm looking at using
> the response headers within the substitute script to work out when to close
> the connection.
>
> * guix/http-client.scm (http-fetch): Return the response as the second value,
> rather than the response-content-length.
> * guix/build/download-nar.scm (download-nar): Adapt accordingly.
> * guix/build/download.scm (url-fetch): Adapt accordingly.
> * guix/scripts/substitute.scm (process-substitution): Adapt accordingly.
Nitpick: use “http-client:” rather than “guix:” as the subject line.
> + (let-values (((port resp)
Conventionally we’d spell it out: ‘response’.
Otherwise LGTM.
Thanks,
Ludo’.