[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48717] [PATCH] Add lingot
From: |
Tobias Geerinckx-Rice |
Subject: |
[bug#48717] [PATCH] Add lingot |
Date: |
Fri, 28 May 2021 19:12:07 +0200 |
Rovanion Luckey 写道:
Added a tuner program to the package collection.
Thank you!
I should add a copyright line for you at the top of the file, once
you confirm which name & e-mail address to use.
I made the following changes (pay close attention, they might be
on the test):
- moved glib:bin to native-inputs, which means it can be run at
build time even when cross-building (and ‘guix gc --references’
indicates it won't be run at run time anyway),
- the licence is ‘GPL2 or later’,
- removed the leading ‘An’ from the synopsis (in a list, it's just
noise),
- wrapped all text to 80 characters and added a double space after
full stops.
Be sure to run ‘guix lint’ on new packages, it will warn you about
some of these and other cool mistakes.
These minor nitpicks will not be on the test but I applied them
anyway:
- reindented the package (specifically the source form was off?),
- ordered the inputs alphabetically, and put the package somewhere
similar,
- removed the libasound comment because that's 99% of why packages
use alsa-lib. Probably 100. Could the same be said for
glib:bin, which I kept? Perhaps! I am whimsy.
Kind regards,
T G-R
signature.asc
Description: PGP signature