guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47898] [PATCH] [core-updates] Add option --xpath0 to xmllint from l


From: david larsson
Subject: [bug#47898] [PATCH] [core-updates] Add option --xpath0 to xmllint from libxml2
Date: Sat, 15 May 2021 21:21:50 +0200

Please also register this patch in gnu/local.mk.  Can you also add your
copyright at the top of xml.scm?

Done!


[...]

+(define-public libxml2-xpath0
+  (package
+    (name "libxml2-xpath0")
+    (version "2.9.10")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "ftp://xmlsoft.org/libxml2/libxml2-";
+                                 version ".tar.gz"))
+             (sha256
+              (base32
+ "07xynh8hcxb2yb1fs051xrgszjvj37wnxvxgsj10rzmqzy9y3zma")) + (patches (list (search-patch "libxml2-Add-option-xpath0.patch")))))

You can inherit another record in Scheme to avoid duplicating all the
fields.  Then the package can be shortened to:

  (define-public libxml2-xpath0
    (package/inherit libxml2
      (name "libxml2-xpath0")
      (source (origin
                (inherit (package-source libxml2))
                (patches (append (search-patches
"libxml2-Add-option-xpath0.patch")
(origin-patches (package-source libxml2))))))
      (description
       "...")))

We should fill out that description to mention how it differs from the
regular libxml2.  Can you give it a try?  I can make the other changes
on your behalf, but not sure what to write.

Thanks,
Marius

Hi, new patch attached. There's a lint warning though: "libxml2-xpath0@2.9.10: no updater for libxml2-xpath0". I don't know what it means, maybe it should be fixed before committing?

Best regards,
David

Attachment: 0001-gnu-libxml2-xpath0-New-package-with-patch-for-xpath0.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]