[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48205] [PATCH] gnu: emacs-org: Make build reproducible
From: |
Ludovic Courtès |
Subject: |
[bug#48205] [PATCH] gnu: emacs-org: Make build reproducible |
Date: |
Tue, 11 May 2021 12:28:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Morgan.J.Smith@outlook.com skribis:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-org)[phases]: Remove loaddefs and use
> autoloads instead
[...]
> + (add-after 'fix-org-version 'use-autoloads
> + (lambda _
> + (delete-file "org-loaddefs.el")
> + (substitute* (find-files "." ".*.el")
> + (("org-loaddefs.el") "org-autoloads.el"))
> + #t))
You can drop the trailing #t.
Could you explain in a comment in the phase what it does? It’s not
clear to me how this relates to making the build bit-reproducible.
Remember that ‘find-files’ takes a regexp as its second argument; thus,
to match .el files, you need to write "\\.el$".
Could you send an updated patch?
Thanks,
Ludo’.