guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#48230] [PATCH] tests: go: Rename and fix duplicate test.


From: Tobias Geerinckx-Rice
Subject: [bug#48230] [PATCH] tests: go: Rename and fix duplicate test.
Date: Tue, 4 May 2021 22:55:48 +0200

* tests/go.scm: Rename "go-version omited 'v' character" to
"go-version without 'v' prefix" and change the code to match.
---

Hi all,

Found on a typo hunt.

This is my best-effort guess at what was intended.  Maybe I'm mistaken: is 
GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead?  Let me 
know!

Kind regards,

T G-R

 tests/go.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/go.scm b/tests/go.scm
index c33a834f69..565a0d451d 100644
--- a/tests/go.scm
+++ b/tests/go.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright � 2021 Fran�ois Joulaud <francois.joulaud@radiofrance.com>
+;;; Copyright � 2021 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
   "v1.0.2"
   (go-version->git-ref "v1.0.2"))
 
-(test-equal "go-version omited 'v' character"
-  "v1.0.2"
-  (go-version->git-ref "v1.0.2"))
+(test-equal "go-version without 'v' prefix"
+  "1.0.2"
+  (go-version->git-ref "1.0.2"))
 
 (test-equal "go-version with embedded git-ref"
   "65e3620a7ae7"
-- 
2.31.1






reply via email to

[Prev in Thread] Current Thread [Next in Thread]