[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47930] [PATCH] gnu: Add pbgzip.
From: |
Efraim Flashner |
Subject: |
[bug#47930] [PATCH] gnu: Add pbgzip. |
Date: |
Thu, 29 Apr 2021 10:29:44 +0300 |
On Thu, Apr 22, 2021 at 06:40:46PM +0200, Maxime Devos wrote:
> Xinglu Chen schreef op wo 21-04-2021 om 23:45 [+0200]:
> > On Wed, Apr 21 2021, Roel Janssen wrote:
> >
> > > [...]
> > > + (arguments
> > > + `(#:phases
> > > + (modify-phases %standard-phases
> > > + (add-after 'unpack 'autogen
> > > + (lambda _
> > > + (zero? (system* "sh" "autogen.sh")))))))
> >
> > IIRC, phases don’t have to return #t, so you could remove ‘zero?’.
>
> Try running (system* "does-not-exist"). It will fail by returning
> something non-zero. If I recall how to call "invoke" correctly,
> I would recommend (invoke "sh" "autogen.sh") here. "invoke" raises
> an exception when the command fails, instead of returning something.
While we're at it, can this phase replace 'bootstrap? It seems to me we
shouldn't need both phases.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
- [bug#47930] [PATCH] gnu: Add pbgzip., Roel Janssen, 2021/04/21
- [bug#47930] [PATCH] gnu: Add pbgzip., Xinglu Chen, 2021/04/21
- [bug#47930] [PATCH] gnu: Add pbgzip., Xinglu Chen, 2021/04/21
- [bug#47930] [PATCH] gnu: Add pbgzip., Maxime Devos, 2021/04/22
- [bug#47930] [PATCH] gnu: Add pbgzip.,
Efraim Flashner <=
- [bug#47930] [PATCH] gnu: Add pbgzip., Roel Janssen, 2021/04/29
- [bug#47930] [PATCH] gnu: Add pbgzip., Xinglu Chen, 2021/04/30
- [bug#47930] [PATCH] gnu: Add pbgzip., Roel Janssen, 2021/04/30
- [bug#47930] [PATCH] gnu: Add pbgzip., Efraim Flashner, 2021/04/30
- bug#47930: [PATCH] gnu: Add pbgzip., Roel Janssen, 2021/04/30