[bug#47768] [PATCH 07/37] gnu: Add ocaml-gen.

[pukkamustard]

Maxime Devos <maximedevos@telenet.be> writes:

> > -(define-public ocaml4.07-gen
> > +(define-public ocaml-gen
> >    [...]
> >     `(#:tests? #f; no tests
> > -       #:package "gen"
> > -       #:ocaml ,ocaml-4.07
> > -       #:findlib ,ocaml4.07-findlib
> > -       #:dune ,ocaml4.07-dune))
> > +       #:package "gen"))
> >      (propagated-inputs
> > -     `(("ocaml-odoc" ,(package-with-ocaml4.07 
> > ocaml4.07-odoc))))
> > +     `(("ocaml-odoc" ,ocaml-odoc)))
> >      (native-inputs
> > -     `(("ocaml-qtest" ,(package-with-ocaml4.07 ocaml-qtest))
> > -       ("ocaml-qcheck" ,(package-with-ocaml4.07 
> > ocaml-qcheck))))
> > +     `(("ocaml-qtest" ,ocaml-qtest)
> > +       ("ocaml-qcheck" ,ocaml-qcheck)))
>
> I'm confused what's going on here.
> ocaml-qtest is for unit tests 
> (https://opam.ocaml.org/packages/qtest/qtest.2.1.0/),
> but for this package we have ‘#:tests? #f; no tests?’?

Excellent catch! There are in fact tests and they also pass. 
Please find
attached updated patch that enables tests (I can also resend the 
entire
patch series as v2 if that is easier).

The `#tests? #f` was introduced with commit
5a4003f453ee8afdfe21d959e105250bfc876063 in 2019 and I blindly 
copied it.

-pukkamustard

0001-gnu-Add-ocaml-gen.patch
Description: Text Data