guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47870] [PATCH 1/2] gnu: polkit-gnome: Add autostart .desktop file.


From: Leo Prikler
Subject: [bug#47870] [PATCH 1/2] gnu: polkit-gnome: Add autostart .desktop file.
Date: Mon, 19 Apr 2021 15:47:55 +0200
User-agent: Evolution 3.34.2

Hi,

Am Montag, den 19.04.2021, 15:30 +0200 schrieb Brendan Tildesley:
> > On 04/19/2021 2:01 PM Leo Prikler <leo.prikler@student.tugraz.at>
> > wrote:
> > 
> >  
> > Am Montag, den 19.04.2021, 13:26 +0200 schrieb Brendan Tildesley:
> > > > On 04/19/2021 1:12 PM Leo Prikler <
> > > > leo.prikler@student.tugraz.at>
> > > > wrote:
> > > > 
> > > >  
> > > > Hi Brendan,
> > > > 
> > > > That's a pretty large package description for something rather
> > > > trivial.
> > > > Would the following work instead?
> > > > 
> > > >   (package/inherit mate-polkit
> > > >     (arguments
> > > >      `(#:phases
> > > >        (modify-phases %standard-phases
> > > >          (add-after 'unpack 'patch-desktop-for-xfce
> > > >            (lambda _
> > > >              (substitute* "src/polkit-mate-authentication-
> > > > agent-
> > > > 1.desktop.in.in"
> > > >                  (("MATE;") "XFCE;"))))))))
> > > > 
> > > > Regards,
> > > > Leo
> > > Uhh ok it's simpler source code but now we're building it twice,
> > > potentially having two copies of it and the .desktop file will
> > > have
> > > the same filename and thus conflict if both desktops are
> > > installed.
> > Oh, right, I was missing the part, in which we rename it.
> > W.r.t. "building it twice", that's only if you have both mate-
> > polkit
> > and the new one in your profile, in which case I guess it would be
> > tolerable.  If you're using just MATE or just XFCE you'll build one
> > or
> > the other.
> > 
> > FWIW, there is also xfce-polkit [1], but it was last updated 2020
> > with
> > the latest release in 2018 (which is still more recent than 2011,
> > though).  WDYT?
> > 
> > [1] https://github.com/ncopa/xfce-polkit
> 
> Yeah I saw these but there is next to zero information on them.
> I packaged it and it seems worse. It doesn't even have OK/Cancel
> buttons
> for mouse operation in the password entry dialogue. It uses
> libxfce4ui
> and has "xfce" in the name but otherwise doesn't seem any more or
> less
> suitable for xfce than other agents.
Fair enough, so it's either gnome or mate for XFCE.

> At this point I just want to pick one and get it done with. If you
> like
> I can make mate-polkit like your suggestion but rename the desktop
> file
> so it doesn't conflict.
It's your choice, what you want to implement:
1. gnome-polkit with an added desktop file (but please use an aux file
or make-desktop-file-entry instead of an origin pointing into the
aether)
2. mate-polkit-for-xfce with the renamed desktop file.
3. something completely else

I know that waiting long for your patch to be upstreamed can be
frustrating, but I'm not here to tease you; rather I want to ensure,
that whatever you do ends up not as a quick and dirty fix, but a proper
package.

> Debian's package says this on gnome-polkit:
> "This implementation was originally designed for GNOME 2, but most
> GNOME-based desktop environments, including GNOME 3, GNOME Flashback,
> and MATE, have their own built-in PolicyKit agents and no longer use
> this one. The remaining users of this implementation are Cinnamon,
> XFCE and Unity. "
Hmm, in that case keeping gnome-polkit around longer might be desirable
if people want to port Cinnamon or Unity.  What does Debian's desktop
file look like and could we port it over?

Regards,
Leo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]