[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47852] [PATCH] gnu: Add sc-im
From: |
Xinglu Chen |
Subject: |
[bug#47852] [PATCH] gnu: Add sc-im |
Date: |
Sun, 18 Apr 2021 11:25:28 +0200 |
Thank you for working on this! I have some comments to add.
> * gnu/packages/visidata.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
I suggest adding it to (gnu packages terminals) instead of creating a
new file. You will find asciinema and fzf there.
> +(define-public sc-im
> + (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
> + (package
> + (name "sc-im")
> + (version "0.8.1")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/andmarti1424/sc-im")
> + (commit commit-ref)))
Why not just use ‘version’, or (string-append ... version) if needed?
> + (file-name (git-file-name name version))
Indentation is a bit off here.
> + (synopsis "Spreadsheet program with vim-like keybindings")
> + (description
> + "@code{sc-im} is a highly configurable spreadsheet program
> + providing a vim-like experience. @code{sc-im} supports @{gnuplot}
> interaction,
> + functions for sorting and filtering, 256 color support, and much more.")
> + (home-page "https://github.com/andmarti1424/sc-im")
Nit: ‘home-page’ usually goes above ‘synopsis’.
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/17
- [bug#47852] [PATCH] gnu: Add sc-im, Jack Hill, 2021/04/17
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/17
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/17
- [bug#47852] [PATCH] gnu: Add sc-im,
Xinglu Chen <=
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/18
- [bug#47852] [PATCH] gnu: Add sc-im, Xinglu Chen, 2021/04/18
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/18
- [bug#47852] [PATCH] gnu: Add sc-im, Xinglu Chen, 2021/04/19
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/19
- [bug#47852] [PATCH] gnu: Add sc-im, Ekaitz Zarraga, 2021/04/19
- [bug#47852] [PATCH] gnu: Add sc-im, Leo Famulari, 2021/04/20
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/22
- [bug#47852] [PATCH] gnu: Add sc-im, jgart, 2021/04/23
- [bug#47852] [PATCH] gnu: Add sc-im, Leo Famulari, 2021/04/23