[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47769] [PATCH 5/6] gnu: Added go-github-com-google-gousb.
From: |
Maxime Devos |
Subject: |
[bug#47769] [PATCH 5/6] gnu: Added go-github-com-google-gousb. |
Date: |
Wed, 14 Apr 2021 23:31:31 +0200 |
User-agent: |
Evolution 3.34.2 |
On Wed, 2021-04-14 at 05:20 -0500, Martin Becze wrote:
> +(define-public go-github-com-google-gousb
> + (package
> + (name "go-github-com-google-gousb")
> + (version "2.1.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/google/gousb.git")
> + (commit (string-append "v" version))))
> + (sha256
> + (base32
> + "1aki6hk009sicrf7gxy5nkjmj4j7lsy0by4kjgd9bwq8ragfyv5x"))
> + (file-name (git-file-name name version))))
> + (build-system go-build-system)
> + (arguments
> + '(#:import-path "github.com/google/gousb"))
> + (propagated-inputs
> + `(("pkg-config" ,pkg-config)
> + ("libusb" ,libusb)))
Most likely, "pkg-config" should be in native-inputs.
I believe there's a linter that checks whether packages should
be in native-inputs, but I'm not sure if pkg-config is detected.
Consider running ./pre-inst-env guix lint go-github-com-google-gousb.
Also, why is "libusb" in "propagated-inputs" and not in "inputs"?
"inputs" is usually preferred over "propagated-inputs", but there
are valid reasons to use "propagated-inputs" instead.
Greetings,
Maime.
signature.asc
Description: This is a digitally signed message part
- [bug#47769] [PATCH 3/6] gnu: Added go-github-com-caarlos0-spin., (continued)
[bug#47769] [PATCH 2/6] gnu: Added go-github-com-logrusorgru-aurora., Martin Becze, 2021/04/14
[bug#47769] [PATCH 6/6] gnu: Added wally-cli., Martin Becze, 2021/04/14
[bug#47769] [PATCH 4/6] gnu: Added go-github-com-marcinbor85-gohex., Martin Becze, 2021/04/14
[bug#47769] [PATCH 5/6] gnu: Added go-github-com-google-gousb., Martin Becze, 2021/04/14
- [bug#47769] [PATCH 5/6] gnu: Added go-github-com-google-gousb.,
Maxime Devos <=