[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47540] [PATCH] gnu: Add prips.
From: |
Maxime Devos |
Subject: |
[bug#47540] [PATCH] gnu: Add prips. |
Date: |
Thu, 01 Apr 2021 21:44:46 +0200 |
User-agent: |
Evolution 3.34.2 |
Hi,
Some comments on the patch.
On Thu, 2021-04-01 at 15:11 +0200, david larsson wrote:
> [...]
> +(define-public prips
> + (package
> + (name "prips")
> + (version "1.1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://devel.ringlet.net/files/sys/"
> + name "/" name "-" version ".tar.xz"))
> + (sha256
> + (base32
> "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:make-flags (list "CC=gcc")
As "CC=gcc" is a constant, I would write '("CC=gcc") here,
though admittedly this is largely a matter of taste.
Another problem: when cross-compiling, "gcc" will be a
compiler for the build system, not the host system (assuming
I got the terminology right). Instead, write
`(#:make-flags (list (string-append "CC" ,(cc-for-target)))
...)
(The quasiquote ` is important.)
(TODO to self: fix other packages that incorrectly set "CC=gcc" ...)
> + #:phases (modify-phases
> + %standard-phases
%standard-phases shouldn't be on a separate line here.
> + (delete 'configure)
> + (delete 'check)
Prips has some tests, so don't delete this phase.
> + (replace 'install
> + (lambda _
> + (let*
> + ((bin-dir (string-append %output "/bin"))
> + (bin-file (string-append bin-dir "/prips")))
The ((bin-dir ...)) should be on the same line as 'let*'.
> + (mkdir-p bin-dir)
> + (copy-file "prips" bin-file)
> + (chmod bin-file #o700)))))))
Why are you making bin/prips writable? Shouldn't this be
(chmod bin-file #o600) instead?
> + (synopsis "Tool that prints the IP addresses in a given range")
> + (description "Prips can be used to print all of the IP addresses in
> + a given range. This allows the enhancement of tools only work
‘Enhancement’ is rather vague and leaning towards marketing-speak.
I do not have an alternative suggestion however.
> + on one host at a time (e.g. whois).")
> + (home-page "https://devel.ringlet.net/sysutils/prips/")
> + (license license:gpl2)))
I looked at the source code and it seems prips is actually gpl2+.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part