[bug#46699] [PATCH 1/2] gnu: mumble: Update to 1.3.4.

[jgart]

Hi Leo,

These two patches change the logic in the snippet block from list of 
directories to delete to list of directories to keep as well as add indentation 
to the mumble package. This is an addition to commit 
ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.

best regards,

jgart

February 22, 2021 2:09 PM, "jgart" <jgart@dismail.de> wrote:

> Hi Leo,
> 
>> IIRC, the correct tag would be Co-authored-by.
> 
> I attached the updated patch with your suggestions.
> 
>> These lines appear to be noise, some of them definitely are.
> 
> Raghav thinks these might have been introduced by indent.el
> 
> How would you suggest to remove them?
> 
>> Are perl and ruby really required? If so, what for?
> 
> They are for the 'patch-shebangs phase.
> 
> Thank you for taking the time to review these patches,
> 
> jgart
> 
> libremiami.org
> search.libremiami.org
> 
> February 22, 2021 11:18 AM, "Leo Prikler" <leo.prikler@student.tugraz.at> 
> wrote:
> 
>> Hi jgart and all the others listening from LibreMiami,
>> 
>> Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
>> 
>>> Co-author: jgart <jgart@dismail.de>
>>> Co-author: Raghav Gururajan <rg@raghavgururajan.name>
>> 
>>> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
>> 
>> This is not enough of a ChangeLog for the changes made here.
>> 
>>> - `(#:tests? #f ; no "check" target
>>> + `(#:tests? #f ; no "check" target
>>> 
>>> - "no-oss" ; use pulse
>>> - "no-alsa" ; use pulse
>>> + "no-oss" ; use
>>> pulse
>>> + "no-alsa" ; use
>>> pulse
>>> 
>>> - (with-output-to-file "scripts/mumble-overlay"
>>> - (lambda ()
>>> - (format #t "#!~a~%" (which "bash"))
>>> - (format #t "export LD_PRELOAD=\"~a
>>> $LD_PRELOAD\"~%"
>>> - (string-append (assoc-ref outputs "out")
>>> - "/lib/mumble/libmumble.so.1
>>> "))
>>> - (format #t "exec \"${@}\"")))
>>> - #t))
>>> + (with-output-to-file "scripts/mumble-overlay"
>>> + (lambda ()
>>> + (format #t "#!~a~%" (which "bash"))
>>> + (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"
>>> + (string-append (assoc-ref outputs "out")
>>> + "/lib/mumble/libmumble.so.1"
>>> ))
>>> + (format #t "exec \"${@}\"")))
>>> + #t))
>>> 
>>> - (replace 'install ; install phase does not exist
>>> + (replace 'install ; install phase does not
>>> exist
>>> 
>>> - ("mesa" ,mesa) ; avoid bundled
>>> + ("mesa" ,mesa) ; avoid bundled
>>> ("openssl" ,openssl)
>>> - ("opus" ,opus) ; avoid bundled
>>> + ("opus" ,opus) ; avoid bundled
>>> 
>>> - ("speex" ,speex) ; avoid bundled
>>> - ("speexdsp" ,speexdsp))) ; avoid bundled
>>> + ("speex" ,speex) ; avoid bundled
>>> + ("speexdsp" ,speexdsp))) ; avoid bundled
>> 
>> These lines appear to be noise, some of them definitely are.
>> 
>>> - `(("pkg-config" ,pkg-config)
>>> - ("python" ,python)
>>> - ("qttools" ,qttools)))
>>> + `(("perl" ,perl)
>>> + ("pkg-config" ,pkg-config)
>>> + ("python" ,python-wrapper)
>>> + ("qttools" ,qttools)
>>> + ("ruby" ,ruby)))
>> 
>> Regards,
>> Leo

0001-gnu-mumble-Indent-package-definition.patch
Description: Binary data

0002-gnu-mumble-Modify-snippet.patch
Description: Binary data