[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46231] Add emilua
From: |
Nicolas Goaziou |
Subject: |
[bug#46231] Add emilua |
Date: |
Sun, 21 Feb 2021 02:21:42 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Vinícius dos Santos Oliveira <vini.ipsmaker@gmail.com> writes:
> I've created a new package for guix. Here's its definition:
> https://gitlab.com/emilua/emilua/-/snippets/2068658
Thank you!
> Please let me know if it has any issues so I can fix them until it's
> ready for inclusion in the main repository.
There are some issue to fix:
- the name of the custom luajit2 package should be changed. Maybe
openresty-luajit?
- that package should have a proper version and build tag out of it.
- I see that emilua uses #:recursive? set to #true. Could some
submodules could be unbundled by any chance?
- You disabled tests. I would be nice to provide a reason for that.
- You don't need `string-append' in the description. Just write the full
textin a single string.
Could you split this into two patches and send them here, for easier review?
Regards,
--
Nicolas Goaziou
- [bug#46231] Add emilua, Vinícius dos Santos Oliveira, 2021/02/01
- [bug#46231] Add emilua,
Nicolas Goaziou <=
- [bug#46231] Add emilua, Vinícius dos Santos Oliveira, 2021/02/21
- [bug#46231] Add emilua, Nicolas Goaziou, 2021/02/22
- [bug#46231] Add emilua, Vinícius dos Santos Oliveira, 2021/02/23
- [bug#46231] Add emilua, Nicolas Goaziou, 2021/02/24
- [bug#46231] Add emilua, Vinícius dos Santos Oliveira, 2021/02/24
- [bug#46231] Add emilua, Nicolas Goaziou, 2021/02/24
- [bug#46231] Add emilua, Vinícius dos Santos Oliveira, 2021/02/25
- bug#46231: Add emilua, Nicolas Goaziou, 2021/02/27