[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46536] Fix build of materialdecoration.

From: Raghav Gururajan
Subject: [bug#46536] Fix build of materialdecoration.
Date: Mon, 15 Feb 2021 12:41:07 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.7.1

Hi Leo!

* gnu/packages/cmake.scm (cmake-shared) [git-version]: Update to
The git-version field doesn't actually change.  You could annotate
[commit] and [revision] separately, but it usually makes sense to just
say "update to <commit hash>".

* gnu/packages/qt.scm (materialdecoration) [git-version]: Update to
Same here.

[arguments]<#:phases>['remove-3rdparty]: New phase.
Should that be a snippet instead?

<#:phases>['remove-3rdparty]: New phase.
As above.

[arguments]<#:configure-flags>[-DCMAKE_CXX_FLAGS]: New flag.
That's a bit too much nesting.
"[arguments]<#:configure-flags: Add -DCMAKE_CXX_FLAGS"
is probably a better choice.

Otherwise LGTM.

Thanks for the review. I have attached revised patches.


Attachment: 0001-gnu-cmake-shared-Update-to-1.1.0-32.patch
Description: Text Data

Attachment: 0002-gnu-materialdecoration-Update-to-1.1.0-9.patch
Description: Text Data

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]