[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45712] [PATCHES] Improve Python package quality

From: Hartmut Goebel
Subject: [bug#45712] [PATCHES] Improve Python package quality
Date: Sun, 7 Feb 2021 17:59:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

Hi Maxim,

Attached is a small rework of your original patch.  I've made the Python
script standalone, which should make it easier to maintain.  I've also
refactored the tests somewhat and added your copyright information.

Is this OK with you?

I had discussed some change to his original patch with Lars. Can't remember all point, just these:

+ if group not in {'console_scripts', }:

"gui_scripts"m are missing. Using a set there is uncommon, since it is a constant value anyway.

+ # And finally try to load top level modules. This should not have any

+ # side-effects.

I'd try loading the top level module first. As this is a pre-condition for loading the entry-points.


| Hartmut Goebel            |                       |
| | |

reply via email to

[Prev in Thread] Current Thread [Next in Thread]