[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46113] [PATCH] gnu: obs: Update to fb347c.

From: Leo Famulari
Subject: [bug#46113] [PATCH] gnu: obs: Update to fb347c.
Date: Tue, 2 Feb 2021 14:33:22 -0500

On Tue, Feb 02, 2021 at 02:39:03PM +0300, Andrew Tropin wrote:
> > Does it work if we apply that to the 26.1.2 release?
> It should work, originally I wrote a patch for 26.1.2 and later rebased
> the commit on master without any conflicts.
> > It would be a little more precise.
> There was a discussion on irc about it and at the end of the day I would
> prefer to use the commit from master branch, rather than maintaining a
> separate patch, which we will need to remove later, when 26.1.3 or
> another version will be released.
> There were not so many changes since 26.1.2 up to the fb347c, I fluently
> went through them, they are mostly minor and were accepted after the
> pretty strict code review process.
> From what I know it should be safe to use this commit, but I can contact
> upstream devs and additionally clarify that.
> Overall I'm ok with using an exact patch, but prefer using a commit from
> master. WDYT?

Thanks for explaining the process you went through. Based on that, I
agree that your patch is good as proposed.

The patch file doesn't apply to current master. It looks like some other
changes regarding this plugins problem have been done to the obs package
since your changes were made.

Can you rebase it on your end and re-generate the patch? Or is it still

reply via email to

[Prev in Thread] Current Thread [Next in Thread]