[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver
From: |
Ludovic Courtès |
Subject: |
[bug#45948] [PATCH 0/5] Improvements to the Automake SRFI 64 test driver. |
Date: |
Sat, 30 Jan 2021 22:34:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> * build-aux/test-driver.scm (show-help): Add help text for the new --select
> and --exclude options.
> (%options): Add the new select and exclude options.
> (test-runner-gnu): Pass them to the test runner. Update doc.
> (test-match-name*, test-match-name*/negated, %test-match-all): New variables.
> (main): Compute the test specifier based on the values of the new options and
> apply it to the current test runner when running the test file.
> * doc/guix.texi (Running the Test Suite): Document the new options.
I never felt the need for this since most individual files run quickly
enough (and those that don’t should be optimized…), but it can be
useful.
> +;;; XXX: test-match-all is a syntax, which isn't convenient to use with a
> list
> +;;; of test specifiers computed at run time.
> +(define %test-match-all (@@ (srfi srfi-64) %test-match-all))
Since this is an internal procedure in Guile that could vanish anytime,
I recommend copying it here (it’s just 9 lines).
> +The underlying SRFI 64 custom Automake test driver used for the 'check'
> +test suite (located at @file{build-aux/test-driver.scm}) also allows
Maybe shorten to “The underlying test driver (located at
@file{build-aux/test-driver.scm}) also allows”.
I didn’t test it, but it otherwise LGTM.
Ludo’.