guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer take


From: Ludovic Courtès
Subject: [bug#44321] [PATCH 1/6] guix build: 'package-with-source' no longer takes a 'store' parameter.
Date: Sat, 31 Oct 2020 11:17:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Miguel Ángel Arruga Vivas <rosen644835@gmail.com> skribis:

> I've had to re-read some parts of the manual and the code of (guix
> store) a bit to completely understand this one, so thank you for the
> practical lesson too.  :-)

Heheh.  :-)

> To be sure that I understood it: the main difference is that now
> package-with-source _stages_ (wink) the source download up to the gexp
> compilation, isn't it?  If that's the case, this LGTM and my quick
> tests.

Yes, exactly.  Now ‘package-with-source’ inserts an “inert”
<downloaded-file> record as the source of the package.  The file is
actually downloaded when that <downloaded-file> object is “lowered”,
which happens when the package itself is lowered to a derivation.

Thanks for the review!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]