guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.


From: Nicolas Goaziou
Subject: [bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.
Date: Mon, 26 Oct 2020 09:41:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello,

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you. Some comments follow.
> +  ;; There is no tagged release yet.
> +  (let ((tag "0.0.0")

The version is actually "O" according to the "Version" keyword in the
Elisp file, not "0.0.0".

> +        (commit "7fa581524533a9b6b770426e4445e571a69e469d")
> +        (revision "0"))
> +    (package
> +      (name "emacs-xonsh-mode")
> +      (version (git-version tag revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/seanfarley/xonsh-mode.git";)
> +               (commit commit)))
> +         (sha256
> +          (base32 "0lfi2372clkkzi4a940fwparsfhxxzb7bmysfd50n1myakgldri5"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/seanfarley/xonsh-mode";)
> +      (synopsis "Major mode for editing @code{xonsh} files")

  Emacs major mode for editing @file{xonshrc} files

seems slightly more accurate.

> +      (description
> +       "This package implements a major mode for xonsh scripts. The basic

Mind the two spaces after the full stop above.

> +functionality includes syntax highlight for xonsh operators.  Files with the
> +.xonshrc or .xsh extension are automatically opened with this mode.")

@file{.xonshrc} or @file{.xsh} extension

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]