[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43310] [PATCH] gnu: Add lsp-dsp-lib.

From: Alexandros Theodotou
Subject: [bug#43310] [PATCH] gnu: Add lsp-dsp-lib.
Date: Mon, 14 Sep 2020 15:17:48 +0100
User-agent: Evolution 3.34.2

Hi Efraim,

Thanks for the review.

On Mon, 2020-09-14 at 17:02 +0300, Efraim Flashner wrote:
> It looks like everything in the modules directory is vendored. Can we
> build it separately and link it in? 

I asked the author something similar a while back
I think the build system just expects those modules to be there as
sources - not sure if they even build anything to link to. BTW, this is
my initial patch, before the author started to provide an all-inclusive 
tarball in the github releases page:

(define-public lsp-dsp-lib
    (name "lsp-dsp-lib")
    (version "0.5.6")
        (method git-fetch)
        (uri (git-reference
               (url "";)
               (commit (string-append "lsp-dsp-lib-" version))))
        (file-name (git-file-name name version))
    (build-system gnu-build-system)
     `(#:tests? #f ; no tests
       (list "CC=gcc")
       (modify-phases %standard-phases
         (add-before 'build 'copy-modules
           (lambda* (#:key inputs #:allow-other-keys)
             (copy-recursively (assoc-ref inputs "lsp-common-lib")
             (copy-recursively (assoc-ref inputs "lsp-test-fw")
         (replace 'configure
           (lambda _
             (invoke "make" "config" (string-append "PREFIX=" (assoc-
ref %outputs "out")))
     `(("lsp-common-lib" ,(origin
         (method git-fetch)
         (uri (git-reference
                (url "";)
                (commit "lsp-common-lib-1.0.7")))
         (file-name (git-file-name name version))
       ("lsp-test-fw" ,(origin
         (method git-fetch)
         (uri (git-reference
                (url "";)
                (commit "lsp-test-fw-1.0.5")))
         (file-name (git-file-name name version))
    (home-page "";)
    (synopsis "Digital signal processing library")
    (description "The LSP DSP library provides a set of functions that
SIMD-optimized computing on several hardware architectures.  All
currently operate on IEEE-754 single-precision floating-point
    (license license:lgpl3+)))

> Also, I saw that there were a few
> test directories. Are there tests to be built?

Not sure - I don't see a check/test make target (see `make help`)

> > +    (arguments
> > +     `(#:tests? #f ; no tests
> > +       #:make-flags
> > +       (list "CC=gcc")
> This can be cc-for-target
>          (list (string-append "CC=" ,(cc-for-target)))


> > +       (modify-phases %standard-phases
> > +         (replace 'configure
> > +           (lambda _
> > +             (invoke "make" "config" (string-append "PREFIX="
> > (assoc-ref %outputs "out")))
> > +             #t)))))
> We'd rather not use %outputs if possible, but to add it to the
> lambda.
> Also invoke already returns #t
>            (lambda* (#:key outputs #:allow-other-keys)
>              (invoke "make" "config"
>                      (string-append "PREFIX=" (assoc-ref outputs
> "out"))))))))


Please find the updated patch attached.


Attachment: 0001-gnu-Add-lsp-dsp-lib.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]