[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43332] [PATCH] build-system: linux-module: Delete some huge items t
From: |
Ludovic Courtès |
Subject: |
[bug#43332] [PATCH] build-system: linux-module: Delete some huge items that we probably don't need. |
Date: |
Sun, 13 Sep 2020 23:25:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Danny,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * guix/build-system/linux-module.scm (make-linux-module-builder): Delete
> some huge items that we probably don't need.
Yay! I’m fine with either v1 or v2, with one nit:
> + (for-each
> + (lambda (name)
> + (if (file-exists? name)
> + (delete-file-recursively name)))
> + (map
> + (lambda (name)
> + (string-append out-lib-build "/" name))
> + '(;"arch" ; 137 MB ; Note: "scripts/dtc" depends on "arch".
> + ;"tools" ; 44 MB ; Note: is built by our 'build phase.
> + "tools/testing" ; 14 MB
> + "tools/perf" ; 17 MB
> + "drivers" ; 600 MB
> + "Documentation" ; 52 MB
> + "fs" ; 43 MB
> + "net" ; 33 MB
> + "samples" ; 2 MB
> + "sound"))) ; 40 MB
Usually the first argument to ‘map’ and ‘for-each’ is on the same line:
(for-each (lambda …)
If you’re afraid of hitting the 80 char limit or something, then I
suggest defining a local procedure.
Also, use ‘when’ instead of a one-arm ‘if’, for clarity.
Thanks!
Ludo’.