[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43347: [PATCH] services: dovecot: Do not require dovecot to be globa

From: Pierre Langlois
Subject: bug#43347: [PATCH] services: dovecot: Do not require dovecot to be globally installed.
Date: Fri, 11 Sep 2020 22:50:16 +0100
User-agent: mu4e 1.4.13; emacs 27.1

Tobias Geerinckx-Rice writes:

> Pierre,
> Thank you very much for the bug report.
> On 2020-09-11 21:40, Pierre Langlois wrote:
>> I noticed recently my little dovecot mailserver failed to boot, I
>> tracked it down to our service installing a symlink as:
>>   /etc/dovecot/modules -> /run/current-system/profile/lib/dovecot
>> However, I didn't have the dovecot package globally installed, the
>> service does not install it AFAICT.
> Sorry, this is my fault.  I've been slowly merging some Dovecot
> improvements[0] into master.
> While I'm happily replying from the latest Dovecot service, I run it
> in an... idiosyncratic manner that had me write some glue code to test 
> these patches.  I didn't realize that said glue was doing more work
> than I, er, realized.  Too much.

No worries! I see you've reverted the commits so I'll close this.

>> We could extend the service to install dovecot into the global profile,
>> however instead we can just symlink /etc/dovecot/modules to the dovecot
>> package in the store directly.
> Nack.  That just reverts to last week's monolithic Dovecot service
> that doesn't support modules, but now with pointless indirection via
> /etc.  Nor should the service add anything to the system profile, or
> expect the user to do so.
> The fix is to add a ‘modules’ field to the service configuration that,
> exactly like CUPS's ‘extensions’ field, adds module packages like 
> dovecot-pigeonhole to the union directory that /etc/dovecot/modules
> points to.

Ah I see, I wasn't aware of the dovecot modules, the indirection being
pointless with my changes should have been a hint there was something
wrong :-).


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]