[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secre
[bug#43106] [PATCH v3 2/2] services: childhurd: Support installing secrets from the host.
Tue, 01 Sep 2020 22:54:21 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Jan Nieuwenhuizen <email@example.com> skribis:
> Ludovic Courtès writes:
>> Perhaps ‘hurd-vm-service-type’ should unconditionally extend (via
>> ‘service-extension’) ‘secret-service-type’, just to ensure that Hurd VMs
>> always include the secret service.
> Eh, hurd-vm-service lives in the host, the secret-services lives in the
> client; am I missing something? ;-)
Ah no, it’s me. :-)
> We could add a check for secret-service, possibly here
> (define (hurd-vm-disk-image config)
> "Return a disk-image for the Hurd according to CONFIG."
> (let ((os (hurd-vm-configuration-os config))
> (disk-size (hurd-vm-configuration-disk-size config)))
> (inherit hurd-disk-image)
> (size disk-size)
> (operating-system os)))))
> and/or insert if it it's missing...seems a bit over the top to me?
Yes, exactly. We could pass ‘os’ through
(define (secret-service-operating-system os)
(services (cons (service secret-service-type)
(A similar pattern is found in ‘virtualized-operating-system’ and
Thanks for these patches!