guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43034: [PATCH] environment: Set USER and LOGNAME in container


From: Ludovic Courtès
Subject: bug#43034: [PATCH] environment: Set USER and LOGNAME in container
Date: Sun, 30 Aug 2020 23:54:26 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Lars,

Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:

> From 516fecf81c980a020906533cd5135c6a7603a0a1 Mon Sep 17 00:00:00 2001
> From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
> Date: Tue, 25 Aug 2020 10:52:21 +0200
> Subject: [PATCH] environment: Set USER and LOGNAME in container
>
> * guix/scripts/environment.scm (launch-environment/container): Set
>   username environment variables.

Applied!

>                        ;; The same variables as in Nix's 'build.cc'.
>                        '("TMPDIR" "TEMPDIR" "TMP" "TEMP"))
>  
> +            ;; Some programs expect USER and/or LOGNAME to be set.
> +            (setenv "LOGNAME" logname)
> +            (setenv "USER" logname)

I was hesitant because so far we were more or less following the set of
variables exported by the daemon (see nix/libstore/build.cc), but there
were already exceptions (HOME, GUIX_ENVIRONMENT, PS1), and I think
making ‘guix environment -C’ more convenient is what matters.

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]