guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43029: [PATCH v2] offload: Modify the build-machine record to accept


From: Maxim Cournoyer
Subject: bug#43029: [PATCH v2] offload: Modify the build-machine record to accept multiple systems.
Date: Tue, 25 Aug 2020 13:50:43 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello Mathieu!

Mathieu Othacehe <othacehe@gnu.org> writes:

> Hello Maxim,
>
>> +(test-assert (machine-matches? (new-build-machine '("i686-linux"))
>> +                               (build-requirements
>> +                                (system "i686-linux"))))
>> +
>> +;;; A build machine can act as more than one system type, thanks to QEMU
>> +;;; emulation.
>> +(test-assert (machine-matches? (new-build-machine '("armhf-linux"
>> +                                                    "aarch64-linux"
>> +                                                    "i686-linux"
>> +                                                    "x86_64-linux"))
>> +                               (build-requirements
>> +                                (system "armhf-linux"))))
>
> This sounds really nice and the test module is very welcome. Not much to
> say except that it would be nice to update "machines-for-berlin.scm" in
> the "maintenance" repository accordingly.

Thank you for the prompt review!  Merged as 4b5a6fbc9b, which the guix
package itself bumped in commit 29d3569c9c so that a reconfigure and
'herd restart guix-daemon' should enable making use of this new feature.

I'll look into updating the 'machines-for-berlin.scm' file when I have a
chance!

Thanks,

Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]