[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42725] [PATCH] drawpile package (sans upnp)
From: |
raingloom |
Subject: |
[bug#42725] [PATCH] drawpile package (sans upnp) |
Date: |
Sat, 8 Aug 2020 00:50:08 +0200 |
On Fri, 07 Aug 2020 10:34:22 +0200
Mathieu Othacehe <othacehe@gnu.org> wrote:
> Hello,
>
> > + (method url-fetch)
> > + (uri (string-append
> > "https://github.com/drawpile/Drawpile/archive/"
> > + version
> > + ".tar.gz"))
>
> We prefer not to use those github archives that can be re-generated
> and prefer to use "git-fetch" method instead.
Done!
> > + (sha256
> > + (base32
> > + "0brscm95nay31xa1c02n1w144gg9hm8pxwa9sfnis0x5dj2nkrb7"))))
> > + (build-system qt-build-system)
> > + (arguments '(#:tests? #f))
>
> You should explain why tests are not run with a comment.
It didn't generate a "test" target, but I figured out how to enable it.
Now it runs them! Also enabled some more functionality that could be
useful.
> > + (native-inputs
> > + `(("extra-cmake-modules" ,extra-cmake-modules)))
> > + (inputs
> > + `(("giflib" ,giflib)
> > + ("karchive" ,karchive)
> > + ("kdnssd" ,kdnssd)
> > + ("libmicrohttpd" ,libmicrohttpd)
> > + ("libsodium" ,libsodium)
> > + ("libvpx" ,libvpx)
> > + ;("miniupnpc" ,miniupnpc) ;; TODO segfaults for some reason
> >
>
> No need to comment twice.
Makes it easier to enable the dependency and still keep the TODO note
without causing a syntax error.
> > + ("qtbase" ,qtbase)
> > + ("qtkeychain" ,qtkeychain)
> > + ("qtmultimedia" ,qtmultimedia)
> > + ("qtsvg" ,qtsvg)))
> > + (home-page "https://drawpile.net")
> > + (synopsis "Collaborative drawing program")
> > + (description
> > +"Drawpile is a drawing program that lets you share the canvas with
> > other users +in real time.
> > +
> > +Some feature highlights:
> > +Runs on Linux, Windows and OSX
>
> No need to talk about those operating systems I think.
Done.
> > +Shared canvas using the built-in server or a dedicated server
> > +Record, play back and export drawing sessions
> > +Simple animation support
> > +Layers and blending modes
> > +Text layers
> > +Supports pressure sensitive Wacom tablets
> > +Built-in chat
> > +Supports OpenRaster file format
> > +Encrypted connections using SSL
> > +Automatic port forwarding with UPnP")
>
> You could use texinfo to render this list nicely. See "libmemcached"
> package for an example.
>
> Could you send an updated patch?
>
> Thanks,
>
> Mathieu
Thanks for the quick response! Here it is :D
0001-gnu-Added-drawpile-UPnP-support-pending-at-version-2.patch
Description: Text Data