[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42682] [PATCH 2/2] gnu: Add qmk-cli.
From: |
Mathieu Othacehe |
Subject: |
[bug#42682] [PATCH 2/2] gnu: Add qmk-cli. |
Date: |
Mon, 03 Aug 2020 10:26:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
> + (propagated-inputs
> + `(("arm-none-eabi-gcc" ,gcc-arm-none-eabi-7-2018-q2-update)
> + ("avr-gcc" ,avr-toolchain-5)
> + ("avrdude" ,avrdude)
> + ("dfu-programmer" ,dfu-programmer)
> + ("dfu-util" ,dfu-util)
> + ("git" ,git)
> + ("python3" ,python)
> + ("python-appdirs" ,python-appdirs)
> + ("python-argcomplete" ,python-argcomplete)
> + ("python-colorama" ,python-colorama)
> + ("python-flake8" ,python-flake8)
> + ("python-hjson" ,python-hjson)
> + ("python-nose2" ,python-nose2)
> + ("python-yapf" ,python-yapf)))
Do we really need to propagate all those inputs? Can't we hardcode the
path to those tools directly in the sources, if they are not registered at
build time?
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'check 'set-qmk-home
> + (lambda _
> + ;; tests fail without this variable set
> + (setenv "QMK_HOME"
> + "")
Who is supposed to set it otherwise?
> + "A program to help users work with QMK Firmware.")
You also need to elaborate here :)
Thanks,
Mathieu
- [bug#42682] [PATCH 0/2] Qmk cli, Jan Wielkiewicz, 2020/08/02
- [bug#42682] [PATCH 1/2] gnu: Add python-hjson., Jan Wielkiewicz, 2020/08/02
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Jan Wielkiewicz, 2020/08/02
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli.,
Mathieu Othacehe <=
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Jan Wielkiewicz, 2020/08/03
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Mathieu Othacehe, 2020/08/05
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Jan Wielkiewicz, 2020/08/05
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Mathieu Othacehe, 2020/08/07
- [bug#42682] [PATCH 2/2] gnu: Add qmk-cli., Jan Wielkiewicz, 2020/08/07
[bug#42682] [PATCH 1/2] gnu: Add python-hjson., Mathieu Othacehe, 2020/08/03