[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41181] adds emacs-interleave
From: |
Nicolas Goaziou |
Subject: |
[bug#41181] adds emacs-interleave |
Date: |
Mon, 18 May 2020 01:00:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
rdes <address@hidden> writes:
> Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New
> variable.
Thank you for the updated patch. Some comments follow.
> +(define-public emacs-interleave
> + (package
> + (name "emacs-interleave")
> + (version "1.4.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/rudolfochrist/interleave")
> + (commit (string-append "interleave-" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb"))))
Could you move the hash on the line above?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/rudolfochrist/interleave")
Could you move the URI on the line above, too?
> + (synopsis
> + "A minor mode that presents a document buffer next to an orgmode
> buffer")
A synopsis does not start with "A". You may want to use "guix lint" to
spot this.
You might use the summary from the home page:
(synopsis "Emacs minor mode to interleave notes and text books")
> + (description
> + "Interleave is a minor mode that presents a document viewer side
> +by side to an orgmode buffer with your notes relevant to the current
> page.")
"orgmode buffer" -> "an Org buffer"
Could you send an updated patch and merge this with the copyright line
you sent?
Regards,
--
Nicolas Goaziou