[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40925] [PATCH] Add collectd
From: |
Lars-Dominik Braun |
Subject: |
[bug#40925] [PATCH] Add collectd |
Date: |
Mon, 4 May 2020 08:06:29 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Ludo,
> Another option is to patch Makefile.in to avoid the dependency on
> Autoconf/Automake/Libool + this phase.
it’s only a native-input, so should be fine?
> This is incorrect (see patch below, which also includes indentation
> fixes and minor changes to the description to placate ‘guix lint’.)
My bad, forgot to run it :(
> Also, could you add a comment stating whether it’s dual-licensing or
> just that there’s code in both licenses?
Done.
> A one-line comment at the top explaining what it does would be great.
Done.
> Otherwise LGTM. Could you send an updated patch?
See attachment. I’ve also enabled the plugin curl_json, which depends on
libyajl.
Cheers,
Lars
0001-gnu-Add-collectd.patch
Description: Text Data
signature.asc
Description: PGP signature
- [bug#40925] [PATCH] Add collectd,
Lars-Dominik Braun <=