[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40767] [PATCH] gnu: Add maradns.

From: Arun Isaac
Subject: [bug#40767] [PATCH] gnu: Add maradns.
Date: Sun, 26 Apr 2020 15:21:38 +0530

>> guix lint checks for lines longer than 90 characters. Perhaps that's the
>> new policy? See the function report-long-line in guix/lint.scm. It even
>> has a comment noting that we don't warn at 80 characters.
> Yes it's to avoid false positives with hashes and URLs. On the other
> hand, in .dir-locals.el, fill-column variable is set to 78. Maybe we
> would need to be more explicit in the "Coding style" section of the
> manual.

Do please raise this in guix-devel and we could get some consensus on

> Nitpicking, you can use the target argument instead of
> %current-target-system, this way:
> --8<---------------cut here---------------start------------->8---
> (lambda* (#:key native-inputs target #:allow-other-keys)
>          ;; make_32bit_tables generates a header file that is used during
>          ;; compilation. Hence, during cross compilation, it should be
>          ;; built for the host system.
>          (when target
>            (substitute* "rng/Makefile"
>                         (("\\$\\(CC\\) -o make_32bit_tables")
>                          (string-append (assoc-ref native-inputs "gcc")
>                                         "/bin/gcc -o make_32bit_tables")))))
> --8<---------------cut here---------------end--------------->8---
> Feel free to go ahead with this one,

Pushed with suggested change. Thanks! :-)

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]