[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40862] gnu: Add xarchiver.

From: Mathieu Othacehe
Subject: [bug#40862] gnu: Add xarchiver.
Date: Sun, 26 Apr 2020 11:22:21 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello Raghav,

Thanks for this patch. When running 'guix lint' on this patch, I have
the following warnings:

--8<---------------cut here---------------start------------->8---
xarchiver@ the source file name should contain the package name
xarchiver@ the source URI should not be an autogenerated tarball
fetching CVE database for 2020......
fetching CVE database for 2019...
fetching CVE database for 2018...
fetching CVE database for 2017...
xarchiver@ can be upgraded to 0.5b2
--8<---------------cut here---------------end--------------->8---

> +(define-public xarchiver
> +  (package
> +    (name "xarchiver")
> +    (version "")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append ""; name "/archive/"
> +                       version ".tar.gz"))

You should use "git-fetch" method for github repositories (see linter
warning above).

> +       (list
> +        "--disable-plugin")))           ; Not required

Why is it not required?

> +    (synopsis "Graphical Front-end for Archive Operations")

No camel case notation.

> +    (description "Xarchiver is the ultimate solution for handling archives.  
> It
> +is a desktop-environment independent archiver front end.")

"Ultimate" is maybe exaggerated! Also you could elaborate a bit on the
functionalities of this tool.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]