[bug#40691] [PATCH v3 1/1] gnu: Add gromacs.

[Vincent Legoll]

On 22/04/2020 17:38, Ludovic Courtès wrote:

> This v2 looks alright to me, but I got this test failure on x86_64:
>
> --8<---------------cut here---------------start------------->8---
>        Start 13: HardwareUnitTests
> 13/52 Test #13: HardwareUnitTests ...................***Failed    0.04 sec
> [==========] Running 5 tests from 2 test cases.
> [----------] Global test environment set-up.
> [----------] 1 test from CpuInfoTest
> [ RUN      ] CpuInfoTest.SupportLevel
> [       OK ] CpuInfoTest.SupportLevel (0 ms)
> [----------] 1 test from CpuInfoTest (0 ms total)
>
> [----------] 4 tests from HardwareTopologyTest
> [ RUN      ] HardwareTopologyTest.Execute
> [       OK ] HardwareTopologyTest.Execute (6 ms)
> [ RUN      ] HardwareTopologyTest.HwlocExecute
> /tmp/guix-build-gromacs-2020.1.drv-0/gromacs-2020.1/src/gromacs/hardware/tests/hardwaretopology.cpp:88:
>  Failure
> Expected: (hwTop.supportLevel()) >= (gmx::HardwareTopology::SupportLevel::Basic), actual: 
> 4-byte object <01-00 00-00> vs 4-byte object <02-00 00-00>
> Cannot determine basic hardware topology from hwloc. GROMACS will still
>
> work, but it might affect your performance for large nodes.
> Please mail address@hidden so we can try to fix it.
> [  FAILED  ] HardwareTopologyTest.HwlocExecute (5 ms)
> [ RUN      ] HardwareTopologyTest.ProcessorSelfconsistency
> [       OK ] HardwareTopologyTest.ProcessorSelfconsistency (6 ms)
> [ RUN      ] HardwareTopologyTest.NumaCacheSelfconsistency
> [       OK ] HardwareTopologyTest.NumaCacheSelfconsistency (5 ms)
> [----------] 4 tests from HardwareTopologyTest (22 ms total)
>
> [----------] Global test environment tear-down
> [==========] 5 tests from 2 test cases ran. (22 ms total)
> [  PASSED  ] 4 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] HardwareTopologyTest.HwlocExecute
>
>   1 FAILED TEST
>
> […]
>
> The following tests FAILED:
>           13 - HardwareUnitTests (Failed)
> Errors while running CTest
> make: *** [Makefile:99: test] Error 8
> --8<---------------cut here---------------end--------------->8---
>
> Could you check what the test is doing?

I think it tries to get CPU topology from the linux kernel,
which is not particularly useful to test on a build server,
the package may run on completely different hardware.

> It may be reasonable to just skip it.

Hope you don't mind trading a test suite failure for a (harmless)
test suite build warning...

How's the crude disabling in the attached patch v3 look to you ?

And does it fix the failure ?
This test is not failing here (kvm on ryzen).

--
Vincent Legoll

0001-gnu-Add-gromacs.v3.patch
Description: Text Data