[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40753] gnu: spacefm: Add missing dependencies. (v3)

From: Raghav Gururajan
Subject: [bug#40753] gnu: spacefm: Add missing dependencies. (v3)
Date: Wed, 22 Apr 2020 16:22:39 -0400

Hi Jan!

> Right.  So we'll have to wait for those then, right?

Pardon me, I should have communicated better. I was asking to push including
the blockers. Would you be able to please? If not, that's okay.

> Okay, it would be nice to say something about that in the commit
> message.  What about
>     gnu: spacefm: Add dependencies for extra functionality.
>     Adding these inputs provides adds icons, privilege-management and
>     disk-management.

Thanks. Please find the revised patch attached with this email.

> Other than that, LGTM (assuming that it builds).  I'm not really able
> to test it, I assume it works for you as you expected?

Yes, all works good. :-)

> No worries!  I did not have much time this morning and from your ping
> assumed a trivial task.  Teaches me not to assume things.

No, you did not do anything wrong. I should have communicated better.

> I would suggest that when you get an OK on the last dependency for this
> one, you mention this patch again.

Sure. But let me know if you would be able to process the blockers as well.

> Please consider sending patches that depend on eachother in one bug
> report if that makes sense.

Sorry, I did not plan on fixing spacefm. I came across the issues with spacefm
after sending those other patches.


Attachment: 0004-gnu-spacefm-Add-dependencies-for-extra-functionality.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]