[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40684] [PATCH core-updates] guix: self: Use guile with libgc-7.
From: |
Ludovic Courtès |
Subject: |
[bug#40684] [PATCH core-updates] guix: self: Use guile with libgc-7. |
Date: |
Fri, 17 Apr 2020 23:02:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Christopher Baines <address@hidden> skribis:
> Rather than libgc version 8. This should avoid crashes that can occur,
> particularly when loading data in to the Guix Data Service [1].
>
> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40525
>
> * gnu/packages/guile.scm (guile-3.0/libgc-7): New variable.
> * guix/self.scm (specification->package): Use guile-3.0/libgc-7 for guile.
> ---
> gnu/packages/guile.scm | 12 ++++++++++++
> guix/self.scm | 2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
> index 8ccbc22f26..6b7bd492ed 100644
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -309,6 +309,18 @@ without requiring the source code to be rewritten.")
>
> (define-public guile-next guile-3.0)
>
> +(define-public guile-3.0/libgc-7
> + (hidden-package
> + (package
> + (inherit guile-3.0)
> + (propagated-inputs
> + (map (lambda (input)
> + (if (string=? (car input)
> + "bdw-gc")
> + (list "bdw-gc" libgc-7)
> + input))
Nitpicking: please write it as:
`(("bdw-gc" ,libgc-7)
,@(alist-delete "bdw-gc" (package-propagated-inputs guile-3.0)))
as we do elsewhere.
Also, could you add a comment referencing the bug report, so we
immediately see why this variant exists?
OK with these changes, thanks!
Ludo’.