[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40635] [PATCH] gnu: Add emacs-moody.

From: Tobias Geerinckx-Rice
Subject: [bug#40635] [PATCH] gnu: Add emacs-moody.
Date: Wed, 15 Apr 2020 23:18:26 +0200


Alberto Eleuterio Flores Guerrero 写道:
* gnu/packages/emacs-xyz.scm (emacs-moody): New variable.
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a9550ee112..364cec47da 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -507,6 +507,33 @@ Alternatively the menu can be bound globally, for example: @code{(global-set-key [S-down-mouse-3] 'minions-minor-modes-menu)}.")
     (license license:gpl3+)))
+(define-public emacs-moody
+  (let ((commit "2751d36152abcc2ac1479225392182b53f1e02dd")
+        (revision "1"))

There's a ‘v0.5.3’ tag so we can just use that:

 (version "0.5.3")
    (method git-fetch)
    (uri (git-reference
          (url "https://…";)
          ;; ‘Commit’ can really be any git identifier.
          (commit (string-append "v" version))))

and drop the (let …).

+    (package
+      (name "emacs-moody")
+      ;; version 4.0 is a bit old (2018)

Nitpick: ;;-comments are sentences, so capitalise and end with a full stop.

However, IMO no comment is needed. The top release at <> is 0.5.3, and I've grown to ignore the ‘latest release’ badge on GitHub unless there are reasons not to. Too many upstreams forget to move it.

+      (version (git-version "0.5.3" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+ (url "";)
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+ "1xyw4l42053595r76lj8safsx6pj25as0107wd96by3h7dg9m586"))))
+      (build-system emacs-build-system)
+      (home-page "";)
+      (synopsis "Tabs and ribbons for Emacs mode-line")

More nitpicks: ‘…the Emacs mode line’.

+      (description
+ "@code{emacs-moody} provides utilities for displaying elements of +the mode line as tabs and ribbons. It also provides replacements for a few +built-in elements. The biggest differences to similar packages is that

‘…difference[singular] with…’.

+this one is much simpler and much more consistent. When using this package,

I don't know enough about other extensions to judge whether that's true, so I'll give it the benefit of the doubt.

In general: feel free to remove content-free marketing from upstream descriptions.

+then only the color of the mode line changes when a window becomes in-/active.")

You can drop ‘then’ here. I'd write ‘(in)active’ but that might be purely a matter of taste.

No need to send an updated patch; I'll make above changes and push if that's all right with you. I might give others time to chime in if I'm feeling laz^Wgenerous.

Kind regards,


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]