[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40537] [PATCH] gnu: Add bchoppr.

From: Christopher Baines
Subject: [bug#40537] [PATCH] gnu: Add bchoppr.
Date: Tue, 14 Apr 2020 20:06:54 +0100
User-agent: mu4e 1.2.0; emacs 26.3

Alexandros Theodotou <address@hidden> writes:

> These patches add 3 new LV2 plugins by the same author as bsequencer:
> bchoppr
> bshapr
> bjumblr

I've got a couple of comments. It looks to me like it would be clearer
to not have the packages inherit from bsequencer. Some copying in the
package definitions is fine if there are similarities between packages.

The second thing is that I'd try to avoid adding package definitions at
the end of files, just because it can lead to more merge conflicts.

Would you be able to send some updated patches?



Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]