[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40301] [PATCH] Fixed some issues with the patches.

From: John Soo
Subject: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sat, 11 Apr 2020 17:45:47 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Hi Nicolas,

Nicolas Goaziou <address@hidden> writes:

>> +(define-public emacs-psc-ide
>> +  (package
>> +    (name "emacs-psc-ide")
>> +    (version "0.0.0")
> According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
> you need to add a revision number, "0", or "1" at this point.
> ...
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri
>> +        (git-reference
>> +         (url "";)
>> +         (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))
> The commit should be moved in a top-level `let' at the beginning of the
> package definition.
>> +       (file-name (git-file-name name "0.0.0"))
> This should use version, along with the revision number.
>> +    (synopsis "Emacs integration for PureScript's psc-ide tool")
>> +    (description
>> +     "Emacs integration for PureScript's psc-ide tool. Featuring:

Ok I added the revision and the commit and used git-version and
git-file-name. As an aside, what does the revision mean? Maybe if I
really understand it I can submit better patches in the future.

> Description should be made of full sentences. Also, it might be useful
> to explain what "psc-ide" tool is.

I think I clarified the description a little. This was an excellent
detailed review, thank you so much.

Also, I changed inputs->propagated-inputs.



Attachment: 0001-gnu-Add-emacs-psc-ide.patch
Description: psc-ide

reply via email to

[Prev in Thread] Current Thread [Next in Thread]