[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40429] [PATCH] gnu: Add emacs-flymake-shellcheck.
From: |
Nicolas Goaziou |
Subject: |
[bug#40429] [PATCH] gnu: Add emacs-flymake-shellcheck. |
Date: |
Sun, 05 Apr 2020 10:11:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
"LaFreniere, Joseph" <address@hidden> writes:
> Patch file is attached.
Thank you.
> + (inputs
> + `(("shellcheck" ,shellcheck)))
> + (arguments
> + '(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'hardcode-shellcheck-path
> + (lambda _
> + (let ((file "flymake-shellcheck.el"))
> + (chmod file #o644)
> + (emacs-substitute-sexps file
> + ("(defcustom flymake-shellcheck-path"
> + (which "shellcheck")))))))))
You could use `emacs-substitute-variables' here.
However, I wonder if we should add "shellcheck" as an input. Of course,
the package will not work so well if "shellcheck" is not available. But,
as a user, it would not cross my mind to use "flymake-shellcheck"
without it. As another data point, "emacs-flycheck-rust" doesn't add
"rust" as an input.
WDYT?
Regards,
--
Nicolas Goaziou