[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40264] Linphone: 11-add-mediastreamer-v2

From: maxim . cournoyer
Subject: [bug#40264] Linphone: 11-add-mediastreamer-v2
Date: Sun, 05 Apr 2020 00:08:08 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello Raghav,

"Raghav Gururajan" <address@hidden> writes:

> Hi Danny!
>>> + (list
>>> + ;; For fixing definitions.
>> Yes, but why? What would happen if we didn't do it?
> Otherwise, we get `-Werror` flag related compilation errors.

Could you please clarify that in a comment above the patch?

>>> + (origin
>>> + (method url-fetch)
>>> + (uri
>>> + (string-append 
>>> "";
>>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>>> + (file-name "mediastreamer-msfactory.patch")
>> I'm not sure what the outcome of the latest discussion on carrying patches 
>> was.
>> Should we carry patches in Guix now or fetch them from external source?
> I think it's good as long as we use hash to verify. :-)

The problem is that metadata or format of auto-generated patches may
change on a whim.  In past discussions it was decided best to not use
them (that is, it's best to embed a copy of it in Guix sources) [0].


I'll post more comments in your original message.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]