[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39786] [PATCH] Add dragonfly-reverb.
From: |
Alexandros Theodotou |
Subject: |
[bug#39786] [PATCH] Add dragonfly-reverb. |
Date: |
Sat, 21 Mar 2020 19:09:48 +0000 |
User-agent: |
Evolution 3.32.4 |
Hi,
Thanks for the feedback.
Attaching the updated patch. I also removed some unneeded dependencies.
Thanks,
Alex
2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました:
> Hello,
>
> Alexandros Theodotou <address@hidden> writes:
>
> > This patch adds dragonfly reverb, a popular reverb plugin.
>
> Thank you!
>
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (vst (string-append out "/lib/vst"))
> > + (lv2 (string-append out "/lib/lv2")))
> > + (mkdir-p bin)
> > + (mkdir-p vst)
> > + (mkdir-p lv2)
> > +
> > + ;; Install VST
> > + (for-each
> > + (lambda (file)
> > + (install-file file vst))
> > + (find-files "bin" "\\-vst.so$"))
>
> Since you use `install-file' you don't need to `mkdir-p' beforehand,
> i.e., you can drop (mkdir-p vst) above.
>
> > + ;; Install standalone
> > + (install-file "bin/DragonflyRoomReverb" bin)
> > + (install-file "bin/DragonflyHallReverb" bin)
>
> Ditto, you can drop (mkdir-p bin).
>
> > + #t))))))
> > + (inputs
> > + `(("jack" ,jack-1)
> > + ("libx11" ,libx11)
> > + ("mesa" ,mesa)))
> > + (native-inputs
> > + `(("lv2" ,lv2)
> > + ("pkg-config" ,pkg-config)))
> > + (synopsis "Concert hall reverb and room reverb effects")
> > + (description
> > + "Dragonfly Reverb is a bundle of two free audio effects: a
> > concert
> > +hall reverb and a room reverb. Both are available as VST and LV2
> > plugins,
>
> You need to add two spaces after full stops.
>
> Could you send an updated patch?
>
> Regards,
>
0001-gnu-Add-dragonfly-reverb.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part