[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#39739] Here is the patch updated

From: Kyle Meyer
Subject: [bug#39739] Here is the patch updated
Date: Thu, 19 Mar 2020 02:39:27 +0000

Hi Jérémy,

Thanks for the update and for clarifying the license with the author.

Jeremy Korwin-Zmijowski <address@hidden> writes:

> +;;; Copyright © 2020 Jérémy Korwin-Zmijowski <address@hidden>

This has a trivial conflict with master (4a0399e277 at the time I
applied it for testing).  That'd be easy for whoever eventually commits
your patch to clean up, but, if you resend the patch for the other
reasons I mention below, it'd be good to resolve it on your end by
moving that to a newer base.

> +(define-public emacs-ac-geiser
> +  (package
> +    (name "emacs-ac-geiser")
> +    (version "0.1")
> +    (source
> +     (origin

You should specify a `file-name' so that the directory in the store
contains the package name.  Note that you can run `guix lint' to catch
issues like these:

  $ pre-inst-env guix lint emacs-ac-geiser
  gnu/packages/emacs-xyz.scm:21842:5: emacs-ac-geiser@0.1: the source
  file name should contain the package name

> +       (uri (git-reference
> +             (url "";)
> +             (commit "502d18a8a0bd4b5fdd495a99299ba2a632c5cd9a")))

This commit is a couple of commits after the v0.1 tag, so you can
represent that with something like

  (let ((commit "abcdef...")
        (revision "0"))
      (version (git-version "0.1" revision commit))
         (uri (git-reference
               (url "";)
               (commit "abcdef...")))

You can find a good number of examples in emacs-xyz.scm.

Because the author clarified the license in the next commit
(93818c936ee7e2f1ba1b315578bde363a7d43d05), I think that'd be a good
commit to use.

> +       (method git-fetch)
> +       (sha256 (base32 
> "0h2kakb4f5hgzf5l2kpqngalcmc4402lkg1pvs88c8z4rqp2vfvz"))))

Formatting/consistency nit: Most packages put "(base32 ..." on a new
line.  I think the same is true, to a lesser extent, for the value of
propagated-inputs below.

> +    (build-system emacs-build-system)
> +    (propagated-inputs `(("geiser" ,emacs-geiser)
> +                         ("auto-complete" ,emacs-auto-complete)))
> +    (synopsis "Auto-complete backend for geiser")
> +    (description "Provides one auto-complete source for Scheme projects 
> using geiser.")
> +    (license license:bsd-3)
> +    (home-page "";)))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]