[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37305] Allow booting from a Btrfs subvolume [review part 2]

From: maxim . cournoyer
Subject: [bug#37305] Allow booting from a Btrfs subvolume [review part 2]
Date: Wed, 18 Mar 2020 11:27:58 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Ludovic,

Ludovic Courtès <address@hidden> writes:

> Hi Maxim,
> Maxim Cournoyer <address@hidden> skribis:
>>>> +              (error "The store is on a Btrfs subvolume, but the \
>>>> +subvolume name is unknown.
>>>> +Hint: Define the \"btrfs-subvolume-path\" file system property or
>>>> +use the \"subvol\" Btrfs file system option."))))
>>> Rather use ‘raise’ with ‘&message’ and ‘&fix-hint’ conditions.
>> I tried this, but importing (guix utils) to acces &fix-hint caused the init
>> RAM disk to fail mysteriously:
> Oh, my bad.  We should move ‘&fix-hint’ to (guix diagnostics)
> eventually.
> In the meantime, I’d say just raise a ‘&message’ and leave the hint as a
> comment (it’s not supposed to be a user-facing interface).  Or maybe you
> could define a specific error condition type for this?
> Thanks,
> Ludo’.
> PS: I’ll comment on the other bits ASAP!

The remaining, reworked patches for this series are attached below.  If
you don't want to merge the 0001 for now (speeding up tests), I don't
mind too much (though it still provides value to me, when using old

Thanks for your patience :-)


Attachment: 0001-gnu-tests-Reduce-the-time-required-to-run-the-system.patch
Description: Text Data

Attachment: 0002-linux-boot-Refactor-boot-system.patch
Description: Text Data

Attachment: 0003-file-systems-Add-helpers-for-parsing-the-options-str.patch
Description: Text Data

Attachment: 0004-bootloader-grub-Allow-booting-from-a-Btrfs-subvolume.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]