[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multip
[bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get.
Sun, 08 Mar 2020 23:58:51 +0000
mu4e 1.2.0; emacs 26.3
Ludovic Courtès <address@hidden> writes:
> Christopher Baines <address@hidden> scribes:
>> * guix/scripts/substitute.scm (http-multiple-get): Add close-port call.
>> guix/scripts/substitute.scm | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
>> index a88cb5bcfe..e3f5837a8e 100755
>> --- a/guix/scripts/substitute.scm
>> +++ b/guix/scripts/substitute.scm
>> @@ -544,6 +544,7 @@ initial connection on which HTTP requests are sent."
>> (match (drop requests processed)
>> + (close-port p)
> Did you notice a file descriptor leak somewhere?
No, I was looking in to some wierd TLS related errors I had when using
http-multiple-get to query Curiass from the Guix Data Service, and I
noticed that maybe the port wasn't being closed when it should be.
I still haven't done a lot of testing, but I think some of these changes
have helped (although probably not this one).
Description: PGP signature